Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to protein ring and plot #55

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

tulika-jha
Copy link
Contributor

Fixes to protein ring and plot on summary page

♻️ Current situation & Problem

  • target protein value for the user is not retrieved before the view for protein ring renders
  • dates for the bar plot do not appear in a sorted fashion

⚙️ Release Notes

  • addressed the above two issues
  • all credits to Phillip and Andreas!

📚 Documentation

  • None added for now

✅ Testing

  • None added for now

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Contributor

@yanavlall yanavlall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 23.56%. Comparing base (5d94c6c) to head (de7b1df).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   24.30%   23.56%   -0.74%     
==========================================
  Files          67       67              
  Lines        4042     3987      -55     
==========================================
- Hits          982      939      -43     
+ Misses       3060     3048      -12     
Files Coverage Δ
Stronger/Info/SummaryView.swift 42.73% <100.00%> (-5.63%) ⬇️
Stronger/ProteinTracker/ChatWindow.swift 4.07% <ø> (+0.25%) ⬆️
Stronger/ProteinTracker/ProteinRing.swift 97.68% <ø> (ø)
Stronger/MainPage.swift 73.34% <85.72%> (-3.96%) ⬇️
Stronger/ProteinTracker/ProteinStats.swift 85.37% <87.10%> (+1.16%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d94c6c...de7b1df. Read the comment docs.

@tulika-jha tulika-jha merged commit b85a1ba into main Mar 8, 2024
7 checks passed
@tulika-jha tulika-jha deleted the protein_stats_final_fixes branch March 8, 2024 04:26
@tulika-jha tulika-jha restored the protein_stats_final_fixes branch March 12, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants