Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workout Selection Changes #54

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

menahassan
Copy link
Contributor

Workout Selection Changes

♻️ Current situation & Problem

  • create new workout selection file and navigate to it from workout home

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@menahassan menahassan requested a review from terribilis March 7, 2024 21:55
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 299 lines in your changes are missing coverage. Please review.

Project coverage is 24.30%. Comparing base (ecf7823) to head (b2ab087).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   26.23%   24.30%   -1.92%     
==========================================
  Files          66       67       +1     
  Lines        3745     4042     +297     
==========================================
  Hits          982      982              
- Misses       2763     3060     +297     
Files Coverage Δ
Stronger/Exercise/WorkoutHome.swift 5.89% <0.00%> (-0.14%) ⬇️
Stronger/Exercise/WorkoutSelections.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf7823...b2ab087. Read the comment docs.

Copy link
Contributor

@terribilis terribilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@terribilis terribilis merged commit 5d94c6c into main Mar 7, 2024
7 checks passed
@terribilis terribilis deleted the mena-workout-selection-changes branch March 7, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants