Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Button on Home Page to show PDF for estimating portion sizes #52

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

yanavlall
Copy link
Contributor

@yanavlall yanavlall commented Mar 6, 2024

adding_PortionEstimatePDF_yanav

♻️ Current situation & Problem

We wanted to add a PDF to make it easier for users to think about portion sizes so that they are be able to give a more accurate measure of how much of something they ate for a meal.

⚙️ Release Notes

Added a green button on the home page that navigates to the Estimating Portion Size
PDF provided by mentors.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 48.64865% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 26.23%. Comparing base (7c3b1cc) to head (9245e00).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   26.04%   26.23%   +0.19%     
==========================================
  Files          66       66              
  Lines        3710     3745      +35     
==========================================
+ Hits          966      982      +16     
- Misses       2744     2763      +19     
Files Coverage Δ
Stronger/MainPage.swift 77.31% <48.65%> (-8.63%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c3b1cc...9245e00. Read the comment docs.

Copy link
Contributor

@tulika-jha tulika-jha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@yanavlall yanavlall merged commit 89cc660 into main Mar 6, 2024
7 checks passed
@yanavlall yanavlall deleted the adding_PortionEstimatePDF_yanav branch March 6, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants