Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display question and swap question in collaboration rooms #185

Merged
merged 33 commits into from
Oct 31, 2023
Merged

Display question and swap question in collaboration rooms #185

merged 33 commits into from
Oct 31, 2023

Conversation

gycgabriel
Copy link
Contributor

@gycgabriel gycgabriel commented Oct 25, 2023 •
edited
Loading

Fix #80, fix #149, fix #216

@gycgabriel gycgabriel marked this pull request as ready for review October 25, 2023 09:16
ong6
ong6 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@ong6 ong6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@gycgabriel
Copy link
Contributor Author

IT WORKS now@!!!

image

@gycgabriel gycgabriel changed the title Collab room questions Custom question and swap question in collaboration mode Oct 31, 2023
@gycgabriel gycgabriel changed the title Custom question and swap question in collaboration mode Custom question and swap question in collaboration Oct 31, 2023
@gycgabriel gycgabriel changed the title Custom question and swap question in collaboration Display question and swap question in collaboration Oct 31, 2023
@gycgabriel gycgabriel changed the title Display question and swap question in collaboration Display question and swap question in collaboration rooms Oct 31, 2023
@gycgabriel
Copy link
Contributor Author

Added swap question functionality, can click button to swap questions

--> Updates questionId in match + collab service

@gycgabriel gycgabriel merged commit e09d0c5 into master Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ong6 ong6 ong6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gycgabriel @ong6