Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin verification #161

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Fix admin verification #161

merged 2 commits into from
Oct 23, 2023

Conversation

yhtMinceraft1010X
Copy link
Contributor

@yhtMinceraft1010X yhtMinceraft1010X commented Oct 21, 2023

Fixes #143

Admin verification does not work because app.get(), app.post() etc are
used to apply the verification as middleware even though this is not
the correct way to do so.

Let's switch to app.use and decide whether to do the verification in
the middleware using the req.method property.

Copy link
Contributor

@ong6 ong6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - does this mean that we can manually set admins now? - can we do this via the UI or only through BE

@yhtMinceraft1010X
Copy link
Contributor Author

LGTM - does this mean that we can manually set admins now? - can we do this via the UI or only through BE

There's no admin UI as of yet, but the admin service in the backend has routes that allow setting users to admins

@yhtMinceraft1010X yhtMinceraft1010X merged commit 55bd794 into master Oct 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway / Admin service: Fix authorization settings
2 participants