ENH Support numpy 2 #524
Merged
ENH Support numpy 2 #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter produces the following deprecation warning: > DeprecationWarning: numpy.core.defchararray is deprecated and has been renamed to numpy._core.defchararray. The numpy._core namespace contains private NumPy internals and its use is discouraged, as NumPy internals can change without warning in any release. In practice, most real-world usage of numpy.core is to access functionality in the public NumPy API. If that is the case, use the public NumPy API. If not, you are using NumPy internals. If you would still like to access an internal attribute, use numpy._core.defchararray.equal. from numpy.core.defchararray import equal as charEqual Eventually we should start using `numpy.strings` once we move to `numpy>=2.0` since `numpy.char` is deprecated and will not receive updates. From https://numpy.org/doc/stable/reference/routines.char.html#module-numpy.char > This submodule is considered legacy and will no longer receive updates. This could also mean it will be removed in future NumPy versions. The string operations in this module, as well as the numpy.char.chararray class, are planned to be deprecated in the future. Use numpy.strings instead
DanKotlyar
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #515
Uses longdouble over longfloat which was removed in numpy 2.0
Also transition from
numpy.core.defchararraytonumpy.charfor the few string array comparisons we do. Eventually we'll want to usenumpy.stringto get future updates - https://numpy.org/doc/stable/reference/routines.char.html#module-numpy.charMake sure you have read over the developer guide to ease
the review process. These include:
docs/contributors.rst