[WIP] Start working on next results reader #410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file serpentTools/next/results.py contains the in-progress ResultFile and ResultReader implementations. These are heavily inspired by the current ResultsReader, originally developed by @DanKotlyar The basic idea is similar to the DetectorFile and DetectorReader, where the latter can be re-used across multiple files and configured independently. Essentially you can do something like ```python >>> r = ResultReader() >>> r29 = ResultReader(serpentVersion="2.1.29") >>> justK = ResultReader(extras={"ABS_KEFF", }) ``` and then the `.read` method on all these instances to process a file. The ResultFile class doesn't have a lot of functionality beyond storing the resdata, metadata, and dictionaries. The goal is to provide the same functionality as the existing ResultsReader. There are still some tasks that I would like to resolve before merging, some more obvious than others. I will leave them here for posterity - [ ] Variable expansion using the groups (like ``"eig"`` to get eigenvalues -> ``{"ABS_KEFF", "COL_KEFF", ...}`` - [ ] Testing against the current ResultsReader - [ ] Implement more functionality on the ResultFile - [ ] Documentation - [ ] Add to ``serpentTools.next`` through import Marking as [skip ci] to avoid builds as this will be left as a draft for discussion and transparency
|
I still want to get to this, but it will need to be back-ported onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file serpentTools/next/results.py contains the in-progress ResultFile and ResultReader implementations. These are
heavily inspired by the current ResultsReader, originally developed by @DanKotlyar
The basic idea is similar to the DetectorFile and DetectorReader, where the latter can be re-used across multiple files and configured independently. Essentially you can do something like
and then the
.readmethod on all these instances to process a file. The ResultFile class doesn't have a lot of functionality beyond storing the resdata, metadata, and dictionaries. The goal is to provide the same functionality as the existing ResultsReader.There are still some tasks that I would like to resolve before merging, some more obvious than others. I will leave them here for posterity
"eig"to get eigenvalues ->{"ABS_KEFF", "COL_KEFF", ...}serpentTools.nextthrough importMarking as [skip ci] to avoid builds as this will be left as a draft for discussion and transparency
Supports #335