Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue with parsing CSVs with mixed newline delimiters #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/csv.ts
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,8 @@ export async function validateCsv(
}

return new Promise((resolve, reject) => {
Papa.parse(input, {
const config = {
header: false,
// chunkSize: 64 * 1024,
beforeFirstChunk: (chunk) => {
return removeBOM(chunk)
},
Expand All @@ -196,6 +195,12 @@ export async function validateCsv(
},
complete: () => handleParseEnd(resolve),
error: (error: Error) => reject(error),
})
};

if (options.newline) {
config.newline = options.newline;
}

Papa.parse(input, config)
})
}
2 changes: 2 additions & 0 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,13 @@ export interface CsvValidatorVersion {

export interface CsvValidationOptions {
maxErrors?: number
newline?: string
onValueCallback?: (value: { [key: string]: string }) => void
}

export interface JsonValidatorOptions {
maxErrors?: number
newline?: string
onValueCallback?: (
val: JsonTypes.JsonPrimitive | JsonTypes.JsonStruct
) => void
Expand Down