Json format 2.0 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaselton-usds
commented
Jan 23, 2024
| @@ -18,6 +19,8 @@ export async function validateJson( | |||
| ): Promise<ValidationResult> { | |||
| if (version === "v1.1") { | |||
| return JsonValidatorOneOne.validateJson(jsonInput, options) | |||
| } else if (version === "v2.0") { | |||
There was a problem hiding this comment.
@mint-thompson I'm thinking that we'll probably want to update this to support major, minor, and patch versioning, but keeping it consistent with the previous implementation for now.
| @@ -213,6 +274,7 @@ export async function validateJson( | |||
| if (typeof key === "string") { | |||
| metadata[key] = value | |||
| } else { | |||
| // is this where I need to put another check for the modifier information? | |||
There was a problem hiding this comment.
I think this is the right spot for that. These checks that collect values into the local metadata object may have to get updated, since modifiers are part of the METADATA_SCHEMA. It might be useful for us to take a closer look at some of this code to make sure that we get the right approach here. Then, we can add some modifiers to the test fixtures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporating JSON v2.0 validation into the WIP on
tall-format-2.0.These changes now support the v2.0 JSON schema requirements.