Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String compare check #50

Merged
merged 9 commits into from
Aug 5, 2024
Merged

String compare check #50

merged 9 commits into from
Aug 5, 2024

Conversation

shaselton-usds
Copy link
Collaborator

Adding string check protection. These functions are called from a library that consumes user generated files and thus typescript protections can't be guaranteed.

mint-thompson
mint-thompson requested changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@mint-thompson mint-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the isEmptyString and isNonEmptyString are not used anywhere other than the test cases, so it might be best to remove them. The changes to matchesString look good!

@eoverly
Copy link
Collaborator

eoverly commented Aug 5, 2024

Looks good.

@shaselton-usds
Copy link
Collaborator Author

Thanks for the double check @mint-thompson! Removed the unused methods.

@shaselton-usds shaselton-usds merged commit cac349f into main Aug 5, 2024
4 checks passed
@shaselton-usds shaselton-usds deleted the string-compare-check branch August 5, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mint-thompson mint-thompson mint-thompson requested changes

@eoverly eoverly Awaiting requested review from eoverly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaselton-usds @eoverly @mint-thompson