adding a protective check for builtin string functions

CMSgov · Aug 2, 2024 · c425677 · c425677
1 parent 0b0a25a
commit c425677
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/versions/common/csv.ts b/src/versions/common/csv.ts
@@ -140,5 +140,6 @@ export function isValidDate(value: string) {
 }
 
 export function matchesString(value: string, target: string) {
+  if(typeof value !== 'string') return false
   return value.trim().toLocaleUpperCase() === target.trim().toLocaleUpperCase()
 }
diff --git a/test/common/csv.spec.ts b/test/common/csv.spec.ts
@@ -1,5 +1,5 @@
 import test from "ava"
-import { csvColumnName } from "../../src/versions/common/csv.js"
+import { csvColumnName, matchesString } from "../../src/versions/common/csv.js"
 
 test("csvColumnName", (t) => {
   t.is(csvColumnName(0), "A")
@@ -8,3 +8,10 @@ test("csvColumnName", (t) => {
   t.is(csvColumnName(18278), "AAAA")
   t.is(csvColumnName(475254), "AAAAA")
 })
+
+test("matchesString", (t) => {
+  t.is(matchesString("testing", "testing"), true)
+  t.is(matchesString("testing", "tresting"), false)
+  t.is(matchesString(1 as unknown as string, "testing"), false)
+  t.is(matchesString(undefined as unknown as string, "testing"), false)
+})