Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-3563: Allow loading of default data #66

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

jimmyfagan
Copy link
Contributor

@jimmyfagan jimmyfagan commented Dec 13, 2024

JIRA Ticket:
BB2-3563

What Does This PR Do?

This PR adds a setting to add a button to load data from json files instead of from a bb2 server.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:
Any recommended refactors, I'm not normally a FE dev.

Validation

Please run your sample client locally by following the instructions in the readme file, and confirm that the button appears and works as described.

@jimmyfagan jimmyfagan marked this pull request as ready for review December 26, 2024 20:51
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

a time saver for POC

@jimmyfagan jimmyfagan merged commit 3f529c6 into master Jan 6, 2025
1 check passed
@jimmyfagan jimmyfagan deleted the jimmy/bb2-3563-hardcode-default-data branch January 6, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants