Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNDE-2047,2065,2095 #143

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

CNDE-2047,2065,2095 #143

wants to merge 13 commits into from
+4,245 −0

Conversation

joshua-mills-cdw
Copy link
Collaborator

@joshua-mills-cdw joshua-mills-cdw commented Jan 24, 2025 •
edited
Loading

Notes

This PR includes work from three tickets: CNDE-2047,2065,2095

  • Generalized stored procedure for CRS_Case
  • Generalized stored procedure for Rubella_Case
  • Generalized stored procedure for Measles_Case

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

@joshua-mills-cdw joshua-mills-cdw marked this pull request as ready for review January 24, 2025 19:47
upasanapattnaik-eq
upasanapattnaik-eq reviewed Jan 24, 2025
View reviewed changes
liquibase-service/src/main/resources/db/srte/tables/002-alter_imrdbmapping-001.sql
other_attributes,
condition_cd
from missing_records_imrdbmapping
WHERE unique_cd NOT IN (SELECT unique_cd FROM NBS_SRTE.dbo.IMRDBMAPPING);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

upasanapattnaik-eq
upasanapattnaik-eq reviewed Jan 24, 2025
View reviewed changes
liquibase-service/src/main/resources/db/srte/tables/002-alter_imrdbmapping-001.sql
condition_cd
from missing_records_imrdbmapping
WHERE unique_cd NOT IN (SELECT unique_cd FROM NBS_SRTE.dbo.IMRDBMAPPING);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to round out my knowledge base, this is a standard requirement for any STLT environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upasanapattnaik-eq upasanapattnaik-eq upasanapattnaik-eq left review comments

@sveselev sveselev Awaiting requested review from sveselev

@johneipe johneipe Awaiting requested review from johneipe

@rseshadri99 rseshadri99 Awaiting requested review from rseshadri99

@jayasudhasundaram jayasudhasundaram Awaiting requested review from jayasudhasundaram

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshua-mills-cdw @upasanapattnaik-eq