Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding rotating packed bed model #2

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

Adding rotating packed bed model #2

wants to merge 59 commits into from

Conversation

adowling2
Copy link

Main author: Ryan Hughes

@ksbeattie
Copy link
Member

@adowling2 & @Ryan-Hughes-8 are you waiting on a review for this?

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 15, 2023
@adowling2
Copy link
Author

We are using this as a way to share code for development. This won't be released for 6 months.

@Ryan-Hughes-8
added polishing step to notebook
c2cbbad
@Ryan-Hughes-8
working changes 1
565271a
@Ryan-Hughes-8
working changes 2
5298533
@Ryan-Hughes-8
completed upper level RPB block
e83f784
@Ryan-Hughes-8
fixed units, added full model creation, added smooth_max from idaes
4da2c94
@Ryan-Hughes-8
added idaes constants
0f0371d
@Ryan-Hughes-8
changed to ["forward","reverse"] flow direction flag
c7c3f5b
@Ryan-Hughes-8
added time index and changed to [t,z,o,k] indexing
125ac31
@Ryan-Hughes-8
fixing indexing errors
a5512c3
@Ryan-Hughes-8
changed add_equations
f29146f
@Ryan-Hughes-8
added ports
26e515a
@Ryan-Hughes-8
added ports
fae4966
@Ryan-Hughes-8
switched "mode" to "initial_guesses"
635c144
@Ryan-Hughes-8
initial changes for idaes structure
41f6108
@Ryan-Hughes-8
changed transformation config
a607139
@Ryan-Hughes-8
changes for only supporting ads and des sections
0afb519
@Ryan-Hughes-8
added initialization and plotting method
73a038b
@Ryan-Hughes-8
added to initializer
aaac6bf
@Ryan-Hughes-8
added properties to ports
2489965
@Ryan-Hughes-8
additional inlet properties
4bd5ce8
@Ryan-Hughes-8
started adding properties methods to RPB interior
b857a35
@Ryan-Hughes-8
added to init routine
2872748
@Ryan-Hughes-8
scaling value change
91c64ff
@Ryan-Hughes-8
updated notebook
2916743
@Ryan-Hughes-8
removed model snapshots
16e03e0
@Ryan-Hughes-8
notebook update
1eee194
@adowling2
Copy link
Author

Is this PR superseded by #3? Or if this PR has a valuable version of the files, could we merge them into a branch besides main in this repo? @Ryan-Hughes-8

@ksbeattie ksbeattie mentioned this pull request Dec 17, 2024
Open
12 tasks
@ksbeattie
Copy link
Member

Asking in #4 what should be done with this PR now (that #3 has been merged).

@adowling2
Copy link
Author

I think this can get closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ryan-Hughes-8 Ryan-Hughes-8

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adowling2 @ksbeattie @Ryan-Hughes-8