Introduce Section intermediate object to RbtParameterFileSource
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beetelbrox
changed the title
RbtParameterFileSource as first step to parse parameter files into dedicated structures
Beetelbrox
changed the title
RbtParameterFileSource as first step to parse parameter files into dedicated structuresRbtParameterFileSource
|
Closing in favour of #119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step to parse parameter files into properly-typed data structures and not need a stateful parser I've introduced a
Sectionobject insideRbtParameterFileSourcethat corresponds to each one of the sections in the parameter file.To avoid shotgunning changes all over the code I've maintained the API of RbtParameterFileSource but internally data is stored inside
Sectionobjects. Then we can start using this objects from outside the code and progressively move out of the current implementation. Also I reckon we can type this further, we'll discover how as we keep breaking down the filesource.