-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for filters service #312
Add test cases for filters service #312
Conversation
To be worked on after finalization of #310 as it makes significant changes to filters service. |
@@ -145,6 +145,7 @@ export class FiltersService { | |||
} | |||
|
|||
clearFilters(): void { | |||
this.updateFilters(this.defaultFilter); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reasoning for adding this line? Isn't this already covered under the call to updatePresetView
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the most recent change to filters service, the preset view does not contain all filters anymore. Specifically in the current implementation, it excludes hiddenLabels. This ensures that the hidden labels filter and any future filter that is not bound to preset views are properly reset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Fixes part of #295
Type of change:
Changes Made:
Proposed Commit Message:
Checklist: