Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task bar bug #306

Merged
merged 7 commits into from
Dec 6, 2023
Merged

Task bar bug #306

merged 7 commits into from
Dec 6, 2023

Conversation

lawhead
Copy link
Collaborator

@lawhead lawhead commented Dec 2, 2023

Overview

Fixed bugs in matrix position calculations and added parameter for task bar spacing.

Ticket

https://www.pivotaltracker.com/story/show/186539510

Contributions

  • Bug fix in matrix position calculations
  • Added height calculation to limit matrix so it won't overlap with the task bar.
  • Added parameter to specify the task bar padding.
  • Updated demos to use Overpass Mono font.
  • Added README for matrix including recommended parameters and information on troubleshooting layout issues.

Test

  • Ran all unit tests
  • Ran demos related to matrix displays
  • Ran Matrix calibration locally

@lawhead lawhead requested a review from tab-cmd December 2, 2023 00:21
Copy link
Contributor

@tab-cmd tab-cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution! We can test the fix on the home use machine when we look at VEP together in the lab

"value": "0.05",
"section": "bci_config",
"readableName": "Task Bar Padding",
"helpTip": "Specifies the padding around the task bar text. Default: 0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the default!

@lawhead lawhead merged commit 99b8f3f into 2.0.0rc4 Dec 6, 2023
5 of 6 checks passed
@lawhead lawhead deleted the task-bar-bug branch December 6, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants