Skip to content

Commit

Permalink
use the optional None to prevent default list issue
Browse files Browse the repository at this point in the history
  • Loading branch information
tab-cmd committed Nov 17, 2023
1 parent 4c69f33 commit d6bdc5f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
5 changes: 1 addition & 4 deletions bcipy/helpers/visualization.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
# mypy: disable-error-code="attr-defined,union-attr"
# needed for the ERPTransformParams
import logging
from typing import List, Optional, Tuple, Union
from typing import List, Dict, Optional, Tuple, Union
from pathlib import Path
from pathlib import Path
from typing import List, Dict, Optional, Tuple

import matplotlib.pyplot as plt
import mne
Expand All @@ -21,7 +19,6 @@
from bcipy.config import (DEFAULT_DEVICE_SPEC_FILENAME, RAW_DATA_FILENAME,
STATIC_IMAGES_PATH, TRIGGER_FILENAME)
from bcipy.helpers.acquisition import analysis_channels
from bcipy.helpers.triggers import TriggerType, trigger_decoder
from bcipy.helpers.parameters import Parameters
from bcipy.helpers.convert import convert_to_mne
from bcipy.helpers.load import choose_csv_file, load_raw_data
Expand Down
4 changes: 2 additions & 2 deletions bcipy/main.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import argparse
import logging
import multiprocessing
from typing import List
from typing import List, Optional

from psychopy import visual

Expand Down Expand Up @@ -183,7 +183,7 @@ def execute_task(
def _clean_up_session(
display: visual.Window,
daq: ClientManager,
servers: List[LslDataServer] = []) -> bool:
servers: Optional[List[LslDataServer]] = None) -> bool:
"""Clean up session.
Closes the display window and data acquisition objects. Returns True if the session was closed successfully.
Expand Down

0 comments on commit d6bdc5f

Please sign in to comment.