Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/thebe #560

Merged
merged 55 commits into from
Mar 18, 2024
Merged

feature/thebe #560

merged 55 commits into from
Mar 18, 2024

Conversation

danieleguido
Copy link
Collaborator

@danieleguido danieleguido commented Jun 28, 2023

todo

  • Initial exploratory integration
  • Execute cells, get and use raw JSON outputs (pot. without ThebeCell)
  • manage execution state in zustand
  • top-level controls
    • busy state - top level is busy if any cell is busy
    • execute all
    • clear all
    • reset all
    • restart session
  • per cell
    • busy state
    • errors
    • run
    • clear
    • reset
  • Error tray example
  • Refactor & minimise renders
  • move rendering closer to current ArticleCell implementation (as we want to be able to render within the current layers/structure)
  • dismiss z index
  • dev environment setup
  • execution count
  • editing with persistent state
  • pass in proper kernel name - added example
  • bad last used date in local storage (checked this is ok e.g. 2023-11-20T09:47:36.748Z)
  • fix - errors at cells have gone missing
  • parse binderUrl
  • limit top level errors to server and session only
    • modify react-thebe to support this
    • detect server disconnect / session died (needs thebe-react 0.4.1)
  • source map errors
  • Startup Status Example
  • open jupyterlab button
  • clear saved sessions button
  • session name/path not being picked up
  • fix error tray
  • test and confirm a binder launch - with correct repo
  • testing R notebook - different kernel name
  • shutdown (on event, on button press)
    • exit thebe mode
  • setup a test binder instance
  • test isolated mode - ❓html outputs only?
  • reset whole connection / shutdown?
  • check docker build
  • documentation / write up
  • bug - build problem on netlify - configuration issue in jupyter-widgets
  • bug - kernel dying does not trigger error ui after shutdown is pressed

prioritization

  • ipywidgets

for discussion

  • R example - this works when environment is OK and kernelName: 'IR' - this needs to be set from metadata
  • test isolated mode - ❓html outputs only?
  • source map errors in dependencies (cra-rewired?)

thebe changes to push upstream

qr4qXONMjQ

testing notebooks

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for journalofdigitalhistory ready!

Name Link
🔨 Latest commit b655f90
🔍 Latest deploy log https://app.netlify.com/sites/journalofdigitalhistory/deploys/65f8207a5744a80009d95b02
😎 Deploy Preview https://deploy-preview-560--journalofdigitalhistory.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevejpurves
Copy link
Collaborator

deploy failing because of yalc will update this soon

@danieleguido danieleguido marked this pull request as ready for review March 18, 2024 11:11
@danieleguido danieleguido merged commit 55cc735 into develop Mar 18, 2024
4 checks passed
@danieleguido danieleguido deleted the feature/thebe branch March 18, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants