Work up until 74X MC samples #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove obsolete function from MCParticle.h/.cc
Store B-quark information Store single lepton information Store neutrino information (GEN levels)
… checks in ST calculation.
…bles that don't require and pseudo top recosntruction.
| @@ -59,9 +60,11 @@ void Analysis::analyse() { | |||
| bjetWeights = BjetWeights(jets, numberOfBJets); | |||
|
|
|||
| ttbar_plus_X_analyser_->analyse(currentEvent); | |||
| if ( ( currentEvent->getDataType() == DataType::TTJets || currentEvent->getDataType() == DataType::TT_Pythia8 ) && Globals::treePrefix_ == "" ) { | |||
| if ( ( currentEvent->getDataType() == DataType::TTJets_amcatnloFXFX || currentEvent->getDataType() == DataType::TTJets_madgraphMLM ) && Globals::treePrefix_ == "" ) { | |||
There was a problem hiding this comment.
To make this a bit easier in the future I created a feature request in issue #166
| double ht = Event::HT(jets); | ||
| return ht + met->et() + lepton->pt(); | ||
| double ht = 0; | ||
| if ( jets.size() > 0 ) ht = Event::HT(jets); |
There was a problem hiding this comment.
If you are really concerned about having 0 jets, this should got into Event::HT and not here!
|
Except for the block of commented lines in the configs, I am happy with the PR. Before merging, could you please have a look at the travis errors? The code fails to compile. |
| return ht + lepton->pt(); | ||
| else | ||
| return ht + met->et() + lepton->pt(); | ||
|
|
There was a problem hiding this comment.
The alternative is:
// ST = HT + MET + lepton pt
double ht = Event::HT(jets); #HT is already safe for 0 jets
double MET = 0 ? met == 0 : met->et();
double lpt = 0 ? lepton == 0 : lepton->pt();
return ht + MET + lpt;
|
This should be now superseded by #169. @EmyrClement if you are happy with the changes, please merge #169 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a large amount of work, up until the point when 74X MC samples became available.
Top reconstruction
Doug has been working on the Rochester reco method. I've almost implemented the hit fit reco as done in Top-12-028.
74X MC
Mainly update sample names and cross sections, but also some changes for running and recognising TTJet samples.
Lepton pt threshold
I loosened the pt threshold at ntuple production, so we need to apply the tighter final selection here.
General tidy up/debugging
Everything else...