Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: User accessibility information input #353

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

HappyNTH
Copy link
Member

@HappyNTH HappyNTH commented Apr 8, 2023

Implementing accessibilityInfo, allowing users to input any access(ability) requirements and admins/box office to view it (resolves #320)

@HappyNTH HappyNTH self-assigned this Apr 8, 2023
@HappyNTH HappyNTH linked an issue Apr 8, 2023 that may be closed by this pull request
@HappyNTH HappyNTH marked this pull request as ready for review May 6, 2024 21:04
@HappyNTH HappyNTH requested review from atoff and Guidedriver0 May 6, 2024 21:04
@HappyNTH HappyNTH added enhancement Relating to new features prior:med Medium priority (think 'this term') labels May 6, 2024
@HappyNTH HappyNTH force-pushed the feat/accessibility-info-integration branch from 767c7cc to 282fd79 Compare September 1, 2024 22:06
@HappyNTH HappyNTH force-pushed the feat/accessibility-info-integration branch from 282fd79 to cb146ac Compare October 9, 2024 13:16
@HappyNTH HappyNTH requested a review from zst-c October 10, 2024 16:07
components/booking/AccessibilityInput.vue Outdated Show resolved Hide resolved
@click="
() => {
booking.accessibilityInfo = newAccessibility;
updateAPI();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-checking it is the case on the back-end too; will the prod team be emailed about an update made to accessibility info after the booking has been already confirmed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if accessibility info is removed (e.g. the person in the wheelchair is no longer coming, and their seat is taken by somebody else in the family instead), will that also be emailed to prod?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch, and led me to a further investigative chain. I've pulled the PR back to draft, since it's going to need some further API work to go with it to make sure that emails are sent properly.

pages/society/[slug]/index.vue Outdated Show resolved Hide resolved
@zst-c
Copy link
Contributor

zst-c commented Oct 10, 2024

All looks pretty good - just a small number of minor tweaks (or not, just questions), and then good to go

@HappyNTH HappyNTH marked this pull request as draft October 10, 2024 20:27
@HappyNTH HappyNTH force-pushed the feat/accessibility-info-integration branch from 4642757 to 2740efa Compare October 27, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Relating to new features prior:med Medium priority (think 'this term')
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Accessibility Info Input for Bookings
2 participants