signer: Pass policy rejections back to the node #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
202407-signer-rejection-part2
branch
3 times, most recently
from
3e0212f to
423b5f7
Compare
cdecker
force-pushed
the
202407-signer-rejection-part2
branch
from
423b5f7 to
69fd3d7
Compare
When the signer rejects a request we had no indication as to what went wrong until now. With this change we (a) send back the error as if it were a normal response and then (b) print the error in the logs, allowing us to collate the operations causing the rejection with the rejection itself.
cdecker
force-pushed
the
202407-signer-rejection-part2
branch
from
69fd3d7 to
26775e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the signer rejects a request we had no indication as to what went
wrong until now. With this change we (a) send back the error as if it
were a normal response and then (b) print the error in the logs,
allowing us to collate the operations causing the rejection with the
rejection itself.