signer: Capture signer rejections and report them #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a `?` that would prematurely bubble the error up, past the point we'd send a rejection notice to the scheduler. So handle those errors with more care, and we can see when policies fail on the server side, to adjust, tweak and right-size the policies, and act as a regression test suite.
cdecker
force-pushed
the
202407-signer-rejection-report
branch
from
3c46697 to
b5de1cd
Compare
philipr-za
reviewed
Jul 18, 2024
philipr-za
approved these changes
Jul 18, 2024
Randy808
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to capture policy signer rejections too, as they can help us identify problems for false negatives, and can be used to fine-tune policies, or act as a regression test suite should the rejection be a true positive.
Sadly we were not actually sending a rejection, due to a misplaces
?that'd bubble up the error past the reporting spot. This PR addresses that by handling the response in a more fine-grained manner.