gl-testing: Cleaning imports #466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikDeSmedt
force-pushed
the
gl-testing-cleanup
branch
from
5ab4dc5 to
a834cef
Compare
|
I've misconfigured my editor and did some clean-ups which appear to make the tests fail. |
cdecker
reviewed
Jun 17, 2024
| @@ -45,7 +42,7 @@ def root_id(cert_directory): | |||
|
|
|||
|
|
|||
| @pytest.fixture() | |||
| def scheduler_id(root_id): | |||
There was a problem hiding this comment.
These are needed, even if unused, because they build up the tree incrementally, and the dependency ensures the right execution order. I'm positive that is your problem. Fixtures with side-effects are nasty, but I don't know how to better do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.