plugin: Fix parsing of str or int amount_msat #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
20240603-invoice-payload-decode-panic
branch
from
de4599f to
5387a23
Compare
cdecker
force-pushed
the
cln-upgrade-24.02.1
branch
from
c24ba09 to
111b1cf
Compare
cdecker
force-pushed
the
20240603-invoice-payload-decode-panic
branch
from
5387a23 to
4dbb29b
Compare
Just patching this one over for now until we find the root cause.
We had missed this one place where the unit was not being parsed correctly from an amount with a unit attached at the end, resulting in incomplete parses. This fixes that.
cdecker
force-pushed
the
20240603-invoice-payload-decode-panic
branch
from
4dbb29b to
26b57ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didnt implement parsing string correctly, leaving the extension unprased, causing the parser to err.