rs: Reorder the network enum to match the bitcoin crate's enumeration
#429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
20240508-network-enum
branch
from
602ae4d to
e2e37eb
Compare
Randy808
previously approved these changes
May 13, 2024
For a second I thought this might be the cause for a mixup between `signet` and `regtest` but it turned out not to be the case. Anyway it is likely less confusing for future debuggings if the numeric values between these enums is the same, even if we don't really use the rust-bitcoin enum with its numeric value.
cdecker
force-pushed
the
20240508-network-enum
branch
from
49c0776 to
0cce6de
Compare
cdecker
changed the title
bitcoin crate's enumeration
Randy808
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were investigating the switch from signet to regtest in the test
environment, and I misidentified the solution as being an ordering, or
numbering issue in the
enum. Turns out we were using an altogetherdifferent enum in the first place, and that was causing the
issue. Nevertheless, lining these up the same way should prevent
accidental breakage if we end up using the numeric encoding somewhere.
Fixes #434