use cln version manager #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randy808
reviewed
Apr 24, 2024
Randy808
reviewed
Apr 24, 2024
ErikDeSmedt
force-pushed
the
use_cln_version_manager
branch
from
c854834 to
c9eab9e
Compare
Randy808
previously approved these changes
Apr 24, 2024
cdecker
force-pushed
the
use_cln_version_manager
branch
from
c9eab9e to
b0c90a6
Compare
ErikDeSmedt
force-pushed
the
use_cln_version_manager
branch
from
aafaa04 to
7ba870b
Compare
cdecker
force-pushed
the
use_cln_version_manager
branch
from
7ba870b to
7fc2fd0
Compare
ErikDeSmedt
force-pushed
the
use_cln_version_manager
branch
from
9137b98 to
ca2622a
Compare
nepet
force-pushed
the
use_cln_version_manager
branch
from
ca2622a to
7bc8268
Compare
I had some code which ran `lightningd --version` and compared it to the expected output. However, even running this code requires some dependencies to be installed. This is annoying. I disabled the check by default
The `clnvm get-all` command always returned a 0-exit code which indicates success. If an error occurs we now return exit-code `1`. This ensures CI will actually fail if one of the sources is missing or corrupted.
The code is not needed anymore since I've introduced cln-version-manager
In the next version of Core Lightning you can pay invoices before the node is fully synced. This MR has been applied to `v23.08gl1` to ensure your greenlight node can use it immediately.
cdecker
force-pushed
the
use_cln_version_manager
branch
from
7bc8268 to
1750ba0
Compare
cdecker
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a bigger effort to make
gl-testinga stand-alone package. One of the dependencies ofgl-testingis a wide range oflightningd-executables.The
cln_version_managercan download these versions and provide them togl-testing. I've introducedcln_version_mangerbefore. This PR contains a couple of fixes and ensuresgl-testinguses versions managed bycln_version_manager