Update glcli #404
Merged
Update glcli #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Neuroth <[email protected]>
The protobuf version "^4" conflicted with gl-client-py Signed-off-by: Peter Neuroth <[email protected]>
This is needed to be able to call upgradecreds from the cli in case a client still has the key and the creds separated from each other. Signed-off-by: Peter Neuroth <[email protected]>
This commit adapts the cli to recent changes made by the introduction of the credentials blob. It removes the TlsCredentials from the cli but keeps a backwards compatible way by loading them when found instead of the credentials file. This way calling `upgradecreds` can perform an upgrade and returns a new credentials blob containing a rune. Signed-off-by: Peter Neuroth <[email protected]>
nepet
force-pushed
the
202404-update-glcli
branch
from
17fa18e to
2dd615d
Compare
|
ACK 2dd615d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the cli back into a working state.
The following calls shouldn't fail anymore, regardless if the client uses old style separated key/cert or new style credentials:
glcli getinfoglcli scheduler upgradecreds-> should write acredentials.gfsinto the working dir