Refactor Dockerfile #390
Merged
Refactor Dockerfile #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikDeSmedt
force-pushed
the
refactor-docker-file
branch
11 times, most recently
from
82007d1 to
9b7f6a5
Compare
ErikDeSmedt
force-pushed
the
refactor-docker-file
branch
from
9b7f6a5 to
673e08f
Compare
Randy808
reviewed
Mar 20, 2024
Randy808
reviewed
Mar 20, 2024
Randy808
reviewed
Mar 20, 2024
Randy808
reviewed
Mar 20, 2024
ErikDeSmedt
force-pushed
the
refactor-docker-file
branch
from
05fb95c to
6b808e6
Compare
|
@cdecker : The current failure is a flake. Could you re-run the pipeline |
|
Sure, making you an owner of the repo too 👍 |
Randy808
approved these changes
Mar 20, 2024
cdecker
reviewed
Mar 21, 2024
cdecker
reviewed
Mar 21, 2024
cdecker
reviewed
Mar 21, 2024
|
ACK 6b808e6 |
This commit improves the dev-container - faster build-time - improved readability - better caching I've decided to not include any cargo compilation in the container. The main reason is that this compilation from scratch is slow. At build-time the container cannot use our cache in `/tmp/gltesting/target` and `/tmp/gltesting/cargo/registry`.
Made it simpler. In the previous version `mypy` didn't get installed correctly
This should speed up CI drastically
Ensure 8 tests run in paralel
Co-authored-by: Randy <[email protected]>
cdecker
force-pushed
the
refactor-docker-file
branch
from
6b808e6 to
b76b2c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the dev-container