Upgrade VLS to v0.11.0rc1 #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
202301-vls-0.11
branch
from
4d334a6 to
166a807
Compare
Randy808
reviewed
Jan 31, 2024
| @@ -32,7 +32,7 @@ impl Resolver { | |||
| Message::GetChannelBasepoints(_) => true, | |||
| Message::ValidateCommitmentTx(_) => true, | |||
| Message::SignWithdrawal(_) => true, | |||
| Message::ReadyChannel(_) => true, | |||
| Message::SetupChannel(_) => true, | |||
There was a problem hiding this comment.
We probably want to update issue #276 which refers to the outdated ReadyChannel when this merges
cdecker
force-pushed
the
202301-vls-0.11
branch
from
166a807 to
af39f12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for the CLN v23.11 deployment, and addition of
splice support. Splicing operations may not yet be exposed via grpc,
but we need the signer to support them first anyway.
One question for @devrandom is whether the newly introduced
SignerIdis safe to set to a constant in our use-case, since signers are
intended to be clones of each other.