Implement JSON-rpc structs for LSPS2 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikDeSmedt
force-pushed
the
erik/lsps-2-server-rpc-methods
branch
from
6ec8e2b to
a82bca9
Compare
ErikDeSmedt
force-pushed
the
erik/lsps-2-server-rpc-methods
branch
from
ce2d9fa to
eaa1737
Compare
ErikDeSmedt
force-pushed
the
erik/lsps-2-server-rpc-methods
branch
from
43218ef to
62f0aa6
Compare
|
When working further on this PR I've noticed some files became too bulky. |
ErikDeSmedt
force-pushed
the
erik/lsps-2-server-rpc-methods
branch
6 times, most recently
from
c1faee4 to
633ec51
Compare
ErikDeSmedt
force-pushed
the
erik/lsps-2-server-rpc-methods
branch
5 times, most recently
from
bda0e9a to
9a50d66
Compare
cdecker
reviewed
Sep 29, 2023
ErikDeSmedt
force-pushed
the
erik/lsps-2-server-rpc-methods
branch
from
f1a2bef to
9aabaff
Compare
ErikDeSmedt
force-pushed
the
erik/lsps-2-server-rpc-methods
branch
from
9aabaff to
6f3d6b8
Compare
Allow the mapping of error_codes defined in JsonRpc
The `crate::lsps::message`-module was becoming too big. I've decided to separate all files related to LSPS0. The code should better reflect how the LSP-specification is structured. I made the following changes - renamed DateTime to IsoDatetime to prevent some compiler bugs - clippy fixes Follow-up commits for LSPS1 and LSPS2 will follow
Move out all lsps1-schema's to another file
Separate the lsps2-schema's from the message file
Implement a `ShortChannelId`-type and break the flow when an invalid scid is encountered
The cln-rpc crate has a ShortChannelId. We've decided to use that version here. If we ever separate out the primitives from cln_rpc we might be able to use them without breaking changes.
cdecker
force-pushed
the
erik/lsps-2-server-rpc-methods
branch
from
95b30a8 to
2577a17
Compare
cdecker
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented the data-types that are required for LSPS2.