Skip to content

Commit

Permalink
fix(tests): Protect the test_log_rpc from concurrent tests
Browse files Browse the repository at this point in the history
The `nodelet` and the `plugin` were using an absolute path, which
would get clobbered by concurrent tests, which can then lead to
spurious fails. Using relative paths makes this much more stable.
  • Loading branch information
cdecker committed Jan 8, 2025
1 parent 846f38f commit 438243f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion libs/gl-plugin/src/node/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,9 @@ impl Node for PluginNodeServer {
// log entries are produced while we're streaming the
// backlog out, but do we care?
use tokio::io::{AsyncBufReadExt, BufReader};
let file = tokio::fs::File::open("/tmp/log").await?;
// The nodelet uses its CWD, but CLN creates a network
// subdirectory
let file = tokio::fs::File::open("../log").await?;
let mut file = BufReader::new(file).lines();

tokio::spawn(async move {
Expand Down

0 comments on commit 438243f

Please sign in to comment.