Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Customizations marked as optional #53

Closed
wants to merge 1 commit into from
Closed

[fix] Customizations marked as optional #53

wants to merge 1 commit into from

Conversation

Vam-Jam
Copy link
Contributor

@Vam-Jam Vam-Jam commented Jan 3, 2024

Page in question: https://docs.battlesnake.com/api/objects/battlesnake

Marked customization as optional, as some requests do not contain it.

TRACE request{method=POST uri=/end version=HTTP/1.1}: axum::rejection: rejecting request status=422 body="Failed to deserialize the JSON body into the target type: board.snakes[0]: missing field `customization` at line 1 column 999" rejection_type="axum::extract::rejection::JsonDataError"  

@Vam-Jam Vam-Jam requested review from a team as code owners January 3, 2024 22:54
@bvanvugt
Copy link
Member

bvanvugt commented Jan 4, 2024

@Vam-Jam Hey do you have a game ID for an example of this? Would love to dig into what's causing this.

@Vam-Jam
Copy link
Contributor Author

Vam-Jam commented Jan 4, 2024

5ff3e4f6-560c-45ef-857b-2c27e715ed58

@Vam-Jam
Copy link
Contributor Author

Vam-Jam commented Jan 4, 2024

I figured out the issue. Forgot an 's' on the end, that's what happens with trying to code and debug late at night. Sorry about that! Looks like it does always send customizations.

@Vam-Jam Vam-Jam closed this Jan 4, 2024
@bvanvugt
Copy link
Member

bvanvugt commented Jan 4, 2024

Ahhh awesome, okay. That saves me some debugging time :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants