Bug/240 make form code optional #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @towa, I let @benoitblanc have a look to this part. @towa are you working on your own or for BRGM or...? |
|
Thanks, |
|
Hi, do I have to do something to this branch? I'm not sure if my rebasing worked 😅 |
benoitblanc
reviewed
Oct 14, 2022
There was a problem hiding this comment.
Hi @towa , sorry for the delay.
As I do not know if custom code is still relevant, I guess make it optional is a good way to do it.
Just one remark on docstring.
Thanks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the injection of code into the layer forms is made optional.
A Checkbox is added to the ImportGMLAS Panel, the default is to not inject code in forms.
In reference to issue #240