Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular sample updates for MSAL Angular v4 and Angular 19 support #7514

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from

Conversation

jo-arroyo
Copy link
Collaborator

@jo-arroyo jo-arroyo commented Jan 17, 2025

This PR:

  • Updates MSAL Angular docs with MSAL Angular v4 information and Angular 19 support
  • Updates the angular18-standalone-sample to use Angular 19 and renames it angular-standalone-sample. This sample is moved to msal-angular-samples folder.
  • Moves the following samples to the msal-angular-samples folder and ensure they work with MSAL Angular v4:
    • angular-b2c-sample
    • angular16-sample (renamed to angular-modules-sample)
  • Removes the following v3 samples from the msal-angular-samples folder: (they continue to live on in the v3-lts branch)
    • angular-standalone-sample (basic sample that used Angular 16)
    • angular-15-sample
    • angular-17-standalone-sample
  • Updates pipeline with renamed samples
  • Updates roadmap with removal of Angular 19 support

@github-actions github-actions bot added documentation Related to documentation. samples Related to the samples apps for the library. labels Jan 17, 2025
@github-actions github-actions bot added the msal-angular Related to @azure/msal-angular package label Jan 17, 2025
This was referenced Jan 17, 2025
@jo-arroyo jo-arroyo changed the title Angular sample updates Angular sample updates for MSAL Angular v4 and Angular 19 support Jan 17, 2025
@jo-arroyo jo-arroyo marked this pull request as ready for review January 17, 2025 22:21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 219 out of 230 changed files in this pull request and generated no comments.

Files not reviewed (11)
  • samples/msal-angular-samples/angular-b2c-sample/angular.json: Language not supported
  • samples/msal-angular-samples/angular-b2c-sample/package.json: Language not supported
  • samples/msal-angular-samples/angular-b2c-sample/jest.config.js: Evaluated as low risk
  • samples/msal-angular-samples/angular-b2c-sample/README.md: Evaluated as low risk
  • .pipelines/3p-e2e.yml: Evaluated as low risk
  • lib/msal-angular/docs/configuration.md: Evaluated as low risk
  • roadmap.md: Evaluated as low risk
  • lib/msal-angular/docs/angular-universal.md: Evaluated as low risk
  • lib/msal-angular/docs/redirects.md: Evaluated as low risk
  • lib/msal-angular/docs/events.md: Evaluated as low risk
  • lib/msal-angular/FAQ.md: Evaluated as low risk
lib/msal-angular/FAQ.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-angular Related to @azure/msal-angular package samples Related to the samples apps for the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants