Skip to content

Commit

Permalink
Correct the artifact build & test paths for Base Image Auto Update (#…
Browse files Browse the repository at this point in the history
…6223)

Corrected the questionable build path to be actually using the thing it is building. 

## Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

### General Guidelines and Best Practices
- [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing).
- [x] Title of the pull request is clear and informative.
- [x] Description of the pull request includes a concise summary of the enhancement or bug fix.

### Testing Guidelines
- [x] Pull request includes test coverage for the included changes.
- Description of the pull request includes 
	- [x] concise summary of tests added/modified
	- [x] local testing done.  

### Draft PRs
- Open the PR in `Draft` mode if it is:
	- Work in progress or not intended to be merged.
	- Encountering multiple pipeline failures and working on fixes.

_Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
  • Loading branch information
yophilav committed Mar 22, 2022
1 parent 5e51c48 commit def1777
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions builds/e2e/templates/e2e-setup-base-image-update-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ steps:

- pwsh: |
$testDir = '$(Build.SourcesDirectory)/test/Microsoft.Azure.Devices.Edge.Test'
dotnet build $testDir
dotnet build -c Release $testDir
$binDir = Convert-Path "$testDir/bin/Debug/netcoreapp3.1"
$binDir = Convert-Path "$testDir/bin/Release/netcoreapp3.1"
Write-Output "##vso[task.setvariable variable=binDir]$binDir"
displayName: Build tests

Expand Down

0 comments on commit def1777

Please sign in to comment.