Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix stagedUpdateRun PolicyObservedClusterCount and ApprovalRequest name uniqueness #1014

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jwtty
Copy link
Contributor

@jwtty jwtty commented Jan 10, 2025

Description of your changes

  1. When scheduling policy is PickAll, we update PolicyObservedClusterCount to the number of scheduled/bound clusterResourceBindings, instead of -1. For PickFix and PickN, we validate if the number of bindings match the expected count.
  2. Add a random appendix to the name of ClusterApprovalRequest generated to avoid conflicts.
  3. Add more output in one of the integration test to help debugging UT flakes.

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant