Enable GetProductsColumnTypesSerialization test for java #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyzhang929
requested review from
Charles-Gagnon,
chlafreniere and
MaddyDev
as code owners
MaddyDev
reviewed
Dec 12, 2022
| @@ -169,9 +169,6 @@ public async void GetProductsColumnTypesSerializationAsyncEnumerableTest(string | |||
| /// </summary> | |||
| [Theory] | |||
| [SqlInlineData()] | |||
| // Java worker returns timestamps in local time zone | |||
| // https://github.com/Azure/azure-functions-sql-extension/issues/515 | |||
| [UnsupportedLanguages(SupportedLanguages.Java)] | |||
There was a problem hiding this comment.
It's working without any changes?
There was a problem hiding this comment.
Yes - the fix was in my last PR #576 but I accidentally missed pushing up the changes for enabling the test.
MaddyDev
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix was in this PR but I accidentally missed pushing up the changes for enabling the test.