Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous Fixes & Updates #169

Merged
merged 11 commits into from
Jan 7, 2025
Merged

Miscellaneous Fixes & Updates #169

merged 11 commits into from
Jan 7, 2025

Conversation

simonkurtz-MSFT
Copy link
Contributor

Fixes #168

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.

Files not reviewed (4)
  • docs/aca/01-deploy-api-to-aca/global-dotnet9.json: Language not supported
  • docs/aca/03-aca-dapr-integration/index.md: Evaluated as low risk
  • docs/aca/12-optimize-containers/index.md: Evaluated as low risk
  • docs/aca/05-aca-dapr-pubsubapi/index.md: Evaluated as low risk

Copy link

github-actions bot commented Jan 6, 2025

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2025-01-07 19:42 UTC

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 18 changed files in this pull request and generated no comments.

Files not reviewed (13)
  • docs/aca/01-deploy-api-to-aca/global-dotnet9.json: Language not supported
  • docs/aca/03-aca-dapr-integration/index.md: Evaluated as low risk
  • docs/aca/08-aca-monitoring/AppInsightsTelemetryInitializer-Backend.Svc.cs: Evaluated as low risk
  • docs/aca/05-aca-dapr-pubsubapi/index.md: Evaluated as low risk
  • docs/aca/08-aca-monitoring/index.md: Evaluated as low risk
  • docs/aca/08-aca-monitoring/Program-Backend.Svc-dotnet8.cs: Evaluated as low risk
  • docs/aca/08-aca-monitoring/AppInsightsTelemetryInitializer-Frontend.UI.cs: Evaluated as low risk
  • docs/aca/06-aca-dapr-bindingsapi/index.md: Evaluated as low risk
  • docs/aca/08-aca-monitoring/Program-Backend.Svc-dotnet9.cs: Evaluated as low risk
  • docs/aca/08-aca-monitoring/Program-Frontend.UI-dotnet8.cs: Evaluated as low risk
  • snippets/persist-state.md: Evaluated as low risk
  • docs/aca/30-appendix/01-run-debug-dapr-app-vscode.md: Evaluated as low risk
  • docs/aca/12-optimize-containers/index.md: Evaluated as low risk
Comments suppressed due to low confidence (1)

docs/aca/04-aca-dapr-stateapi/index.md:227

  • The word 'authentification' should be corrected to 'authentication'.
--set properties.disableLocalAuth=false
@simonkurtz-MSFT simonkurtz-MSFT marked this pull request as ready for review January 7, 2025 19:40
@simonkurtz-MSFT simonkurtz-MSFT merged commit 6d4e99a into main Jan 7, 2025
3 checks passed
@simonkurtz-MSFT simonkurtz-MSFT deleted the fixes branch January 7, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]
1 participant