Specify event source (#283)

* Cosmetic * Improve event msg precision * Update version * Set source for temp related events * Fix
Azure-Samples · Jul 6, 2023 · e025a45 · e025a45
1 parent ca99cac
commit e025a45
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/src/PluginNodes/Boiler2PluginNodes.cs b/src/PluginNodes/Boiler2PluginNodes.cs
@@ -245,26 +245,26 @@ private void InitEvents()
         _offSpecEv = new DeviceHealthDiagnosticAlarmTypeState(parent: null);
         _maintenanceRequiredEv = new DeviceHealthDiagnosticAlarmTypeState(parent: null);
 
-        // Init the events
+        // Init the events.
         _failureEv.Initialize(_plcNodeManager.SystemContext,
-                    source: null,
-                    EventSeverity.Max,
-                    new LocalizedText($"Temperature is above overheat threshold!"));
+            source: _currentTempDegreesNode,
+            EventSeverity.Max,
+            new LocalizedText($"Temperature is above or equal to the overheat threshold!"));
 
         _checkFunctionEv.Initialize(_plcNodeManager.SystemContext,
-                    source: null,
-                    EventSeverity.Low,
-                    new LocalizedText($"Temperature is above target!"));
+            source: _currentTempDegreesNode,
+            EventSeverity.Low,
+            new LocalizedText($"Temperature is above target!"));
 
         _offSpecEv.Initialize(_plcNodeManager.SystemContext,
-                    source: null,
-                    EventSeverity.MediumLow,
-                    new LocalizedText($"Temperature is off spec!"));
+            source: _currentTempDegreesNode,
+            EventSeverity.MediumLow,
+            new LocalizedText($"Temperature is off spec!"));
 
         _maintenanceRequiredEv.Initialize(_plcNodeManager.SystemContext,
-                    source: null,
-                    EventSeverity.Medium,
-                    new LocalizedText($"Maintenance required!"));
+            source: null,
+            EventSeverity.Medium,
+            new LocalizedText($"Maintenance required!"));
 
         _failureEv.SetChildValue(_plcNodeManager.SystemContext, Opc.Ua.BrowseNames.SourceName, value: "Overheated", copy: false);
         _checkFunctionEv.SetChildValue(_plcNodeManager.SystemContext, Opc.Ua.BrowseNames.SourceName, value: "Check function", copy: false);

diff --git a/tests/Boiler2DeviceHealthEventsTests.cs b/tests/Boiler2DeviceHealthEventsTests.cs
@@ -96,7 +96,7 @@ public void FiresEvent_Failure()
                 });
                 value.Should().ContainKey("/Message")
                     .WhoseValue.Should().BeOfType<LocalizedText>()
-                    .Which.Text.Should().Be("Temperature is above overheat threshold!");
+                    .Which.Text.Should().Be("Temperature is above or equal to the overheat threshold!");
             }
         }
     }

diff --git a/version.json b/version.json
@@ -1,6 +1,6 @@
 {
   "$schema": "https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
-  "version": "2.9.6",
+  "version": "2.9.7",
   "versionHeightOffset": -1,
   "publicReleaseRefSpec": [
     "^refs/heads/main$",