Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Fix op_add with constant #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xsacha
Copy link
Contributor

@xsacha xsacha commented Sep 7, 2021

Fixes #26

@hakanardo
Copy link
Contributor

Please consider adding a test aswell.

@hakanardo
Copy link
Contributor

This could break things as constants might appear in other ops than add. How about keeping the old solution but add an inefficiency warning to it and then we can fix the ops one by one as needed?

@xsacha
Copy link
Contributor Author

xsacha commented Aug 17, 2022

Sorry, I'm unsure about what you mean there. Without this change, the model won't load at all.
For the OnnxConstant, is there an example that fails when b has no size? I can't think of an example for that test.

@xsacha
Copy link
Contributor Author

xsacha commented Nov 2, 2022

Any update on this?
Is there a corner case I need to test? Is there an alternative fix for #26?

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Keras model fails to load after conversion
2 participants