Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom task fixes #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Custom task fixes #1

wants to merge 1 commit into from

Conversation

AvihayTsayeg
Copy link
Owner

  • ChangeSetDelegate.customchange : use change.setClasss instead of direct assignment, the setter instantiate the custom change class.
  • CustomProgrammaticChangeWrapper : add annotation which is required by liquibase infra, change ancestor to CustomChangeWrapper to use implementation which is needed for check-sum generation
  • Align custom task and custom pre condition to use same parameter className. I found it confusing and even in this repo there was a mistake.

@tzachz
Copy link

tzachz commented Jul 21, 2014

did you intentionally fork this to your own account and not Kenshoo's?

@AvihayTsayeg
Copy link
Owner Author

No, we already have a repo with that name it did not allow me to do it.

@AvihayTsayeg AvihayTsayeg changed the title small fixes + adding tests + name alignment of custom class (task,precon... Custom task chnages Jul 21, 2014
@AvihayTsayeg AvihayTsayeg changed the title Custom task chnages Custom task fixes Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants