Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect TextBox.VerticalContentAlignment for inner contents in fluent theme #17932

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

heartacker
Copy link
Contributor

Update TextBox.xaml

What does the pull request do?

align innerleft and innerright content

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

fix #17931

Update TextBox.xaml
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0054167-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@cla-avalonia
Copy link
Collaborator

cla-avalonia commented Jan 9, 2025

  • All contributors have signed the CLA.

@heartacker
Copy link
Contributor Author

@cla-avalonia agree

@MrJul MrJul added area-fluent Fluent theme related bug labels Jan 9, 2025
Copy link
Member

@MrJul MrJul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@MrJul
Copy link
Member

MrJul commented Jan 9, 2025

For reference, the simple theme doesn't exhibit this issue.

@MrJul MrJul added this pull request to the merge queue Jan 9, 2025
@MrJul MrJul changed the title fix #17931 Respect TextBox.VerticalContentAlignment for inner contents in fluent theme Jan 9, 2025
Merged via the queue into AvaloniaUI:master with commit a647c5c Jan 9, 2025
11 checks passed
@heartacker heartacker deleted the patch-1 branch January 10, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-fluent Fluent theme related bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

innerText do not respect VerticalAlignment or VerticalContentAlignment
4 participants