Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRDB: Podcast Data Manager #2584

Draft
wants to merge 6 commits into
base: grdb/initial-setup
Choose a base branch
from

Conversation

leandroalonso
Copy link
Member

This is another PR that adds a GRDB layer for PodcastDataManager. As the previous one, this works by duplicating and adapting the code.

We're having discussions in the initial PR about having a more generic layer that can work with both. I'm pushing this PR just so we can test GRDB.

To test

  1. Run the app
  2. Open a few podcasts
  3. ✅ Ensure everything works as usual

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added the [Type] Tech Debt Applies to issues involving upgrades or refactoring to maintain or enhance the codebase. label Dec 23, 2024
@leandroalonso leandroalonso added this to the Future milestone Dec 23, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@pocketcasts
Copy link
Contributor

Pocket Casts Prototype Build📲 You can test the changes from this Pull Request in Pocket Casts Prototype Build by scanning the QR code below to install the corresponding build.
App NamePocket Casts Prototype Build Pocket Casts Prototype Build
Build Numberpr2584-4ffdbde
Version7.79
Bundle IDau.com.shiftyjelly.podcasts.prototype
Commit4ffdbde
App Center BuildPocket Casts - Prototype Builds #41
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Tech Debt Applies to issues involving upgrades or refactoring to maintain or enhance the codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants