Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hack Week] Serial show support #2502

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

SergioEstevao
Copy link
Contributor

| 📘 Part of: # |
|:---:|

Fixes #

This PR adds support for improved fiction shows, AKA serial shows, that have season and episode information. For example "White Vault".
The changes done are inspired in this blog post: https://www.theend.fyi/article/unlocking-the-potential-of-fiction-podcasts-a-call-to-podcast-app-developers

It adds the following features:

  • A new sort type, Serial, that orders the episode by ascending season number and episode number
  • Episodes that don't have a Season and Episode number are group in section called Extras in the end of the list of episodes
  • By default if a podcast is added and it has the showType == serial the default sort order for the episodes is set to Serial and Grouping by Season
  • Adds a new button to support download of all episodes of a season.

Here are some videos of the feature:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-04.at.16.26.55.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-04.at.15.02.20.mp4

This is still a proof of concept but would like feedback on the following:

  • A better name for the sort type, Serial does not look like a obvious name
  • Where to add the download section button, the header may not be the best option, we could also consider an option on Multiselect that allows to select a complete season, and then users press download on the options button?

To test

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added [Type] Enhancement Improve an existing feature. Needs design This issues needs design input labels Dec 4, 2024
@SergioEstevao SergioEstevao added this to the 7.79 milestone Dec 4, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 4, 2024

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@CookieyedCodes
Copy link

I would love this , one nice suggestion I would have tho if the tital of the season is tapped it hides that season from view 🤔🤔

# Conflicts:
#	podcasts/en.lproj/Localizable.strings
@SergioEstevao SergioEstevao marked this pull request as ready for review December 6, 2024 12:03
@SergioEstevao SergioEstevao requested a review from a team as a code owner December 6, 2024 12:03
@SergioEstevao SergioEstevao requested review from danielebogo and david-gonzalez-a8c and removed request for a team December 6, 2024 12:03
@SergioEstevao SergioEstevao modified the milestones: 7.79, 7.80 Dec 9, 2024
@SergioEstevao
Copy link
Contributor Author

Version 7.79 has now entered code-freeze, so the milestone of this PR has been updated to 7.80.

@danielebogo danielebogo modified the milestones: 7.80, 7.81 Jan 6, 2025
@danielebogo
Copy link
Contributor

Version 7.80 has now entered code-freeze, so the milestone of this PR has been updated to 7.81.

@SergioEstevao SergioEstevao modified the milestones: 7.81, 7.82 Jan 20, 2025
@SergioEstevao
Copy link
Contributor Author

Version 7.81 has now entered code-freeze, so the milestone of this PR has been updated to 7.82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs design This issues needs design input [Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants