Social | Restore must_reauth as connection status #40946

manzoorwanijk · 2025-01-10T05:56:56Z

When we brought connections management to wp-admin, we set the connection status only to 'ok' or 'broken'. Then, in #40539, we made changes to the front-end logic to remove the usage of must_reauth status.

It seems like we will still need that must_reauth status for LinkedIn connections.

Proposed changes:

Add must_reauth as status in the connections schema
Revert UI changes made in Social: Connections API schema front end changes #40539, related to must_reauth

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Goto connections management
Ensure that the connections are marked as healthy (not broken)
Break a connection
- For Mastodon, remove Jetpack here.
- For Facebook, remove Jetpack here.
Confirm that the broken connections in the editor are marked as such and the notices appear.
I am not sure how to test the must_reauth status.

github-actions · 2025-01-10T05:57:46Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-add-back-must_reauth-as-connection-status branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/social-add-back-must_reauth-as-connection-status

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-01-10T05:57:59Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice.

pablinos

This is working well for me. I made a minor tweak so that must_reauth connections aren't disabled.

It's not for this PR, but we need to fix the notices we're displaying.

The LinkedIn one is inline and links to Calypso, and the list of broken connections is too verbose for me. In this instance my test site still has a twitter connection that makes matters worse.

We should probably swap back to a more general message that we replaced in #38450 and put more description in the modal. We could also put the connection icon in a different state. Perhaps with an additional icon or colour change.

* Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Social: Connections API schema front end changes (#40539) * Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Update connect-form.tsx * Create connections class for caching * Update types for connection object * Update connection actions to reflect new types * Mark 'id' as deprecated * Add changelog * Deprecated fields should be optional * Fix TS error * Update unit tests * Replace/remove deprecated props usage * Remove unused code * Fix connection selectors * Fix unit tests * Reduce the number of changes * Fix type * Oops! It should be negation * Restore class-connections.php * Social | Add site context for publicize endpoints (#40704) * Allow requests as blog in base controller * Add filters for connections controller * Add changelog * Update baseline.php * Rename the 'include' param to 'scope' for clarity * Return shared connections by default * Remove scope parameter in favour of request context * Only pass test_connections to WPCOM * Update baseline.php * Social: Implement connections caching with the updated endpoint (#40892) * Update connections class to implement caching * Add get_all_for_user method * Pass cached connections to initial state * Invalidate cache on XMLRPC request * Add changelog * Remove eager loading of connections following cache invalidation * Improve clear caching logic to handle race condition * Social: Replace can_disconnect with a store data selector (#40888) * Pass the connected users WPCOM data to the UI * Augment wpcom for user object * Create canUserManageConnection selector * Replace can_disconnect with the new selector * Fix unit tests * Add changelog * Fix user data for WPCOM sites * Fix unit tests * Add changelog * Social | Restore must_reauth as connection status (#40946) * Add "must_reauth" to status in REST schema * Restore the UI changes to consider must_reauth status * Add changelog * Don't disable connections with must_reauth status must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice. --------- Co-authored-by: Paul Bunkham <[email protected]> * Social | Clean up connections controller to use connections class (#40982) * Create Proxy_Requests class for re-usability * Move is_wpcom utility to Publicize_Utils class * Move connections specific logic from REST controller to connections class * Add changelog * Update baseline.php * Move publicize permissions check to its own method * Social | Fix connect button for broken connections (#40995) * Social | Fix connected accounts not marked as such on confirmation screen (#40997) * Social | Fix connected accounts not marked as such on confirmation screen * Add a comment * Social | Update connections schema to change `user_id` to `wpcom_user_id` (#41025) * Social | Update connections schema to change user_id to wpcom_user_id * Fix wpcom_user_id for post connections field * Add changelog * Social | Implement the other CRUD operations for connections (#40928) * WIP * Pass the connection ID in the URL * Pass connection_id for delete proxy request * Allow overriding $request_options * Clean up debugging * Add changelog * Add changelog for js changes * Fix static analysis issues * Remove unused code * Update baseline.php --------- Co-authored-by: Paul Bunkham <[email protected]> * Unify changelogs --------- Co-authored-by: Paul Bunkham <[email protected]>

* Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Social: Connections API schema front end changes (#40539) * Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Update connect-form.tsx * Create connections class for caching * Update types for connection object * Update connection actions to reflect new types * Mark 'id' as deprecated * Add changelog * Deprecated fields should be optional * Fix TS error * Update unit tests * Replace/remove deprecated props usage * Remove unused code * Fix connection selectors * Fix unit tests * Reduce the number of changes * Fix type * Oops! It should be negation * Restore class-connections.php * Social | Add site context for publicize endpoints (#40704) * Allow requests as blog in base controller * Add filters for connections controller * Add changelog * Update baseline.php * Rename the 'include' param to 'scope' for clarity * Return shared connections by default * Remove scope parameter in favour of request context * Only pass test_connections to WPCOM * Update baseline.php * Social: Implement connections caching with the updated endpoint (#40892) * Update connections class to implement caching * Add get_all_for_user method * Pass cached connections to initial state * Invalidate cache on XMLRPC request * Add changelog * Remove eager loading of connections following cache invalidation * Improve clear caching logic to handle race condition * Social: Replace can_disconnect with a store data selector (#40888) * Pass the connected users WPCOM data to the UI * Augment wpcom for user object * Create canUserManageConnection selector * Replace can_disconnect with the new selector * Fix unit tests * Add changelog * Fix user data for WPCOM sites * Fix unit tests * Add changelog * Social | Restore must_reauth as connection status (#40946) * Add "must_reauth" to status in REST schema * Restore the UI changes to consider must_reauth status * Add changelog * Don't disable connections with must_reauth status must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice. --------- Co-authored-by: Paul Bunkham <[email protected]> * Social | Clean up connections controller to use connections class (#40982) * Create Proxy_Requests class for re-usability * Move is_wpcom utility to Publicize_Utils class * Move connections specific logic from REST controller to connections class * Add changelog * Update baseline.php * Move publicize permissions check to its own method * Social | Fix connect button for broken connections (#40995) * Social | Fix connected accounts not marked as such on confirmation screen (#40997) * Social | Fix connected accounts not marked as such on confirmation screen * Add a comment * Social | Update connections schema to change `user_id` to `wpcom_user_id` (#41025) * Social | Update connections schema to change user_id to wpcom_user_id * Fix wpcom_user_id for post connections field * Add changelog * Social | Implement the other CRUD operations for connections (#40928) * WIP * Pass the connection ID in the URL * Pass connection_id for delete proxy request * Allow overriding $request_options * Clean up debugging * Add changelog * Add changelog for js changes * Fix static analysis issues * Remove unused code * Update baseline.php --------- Co-authored-by: Paul Bunkham <[email protected]> * Unify changelogs * Unify js changelog * It should be 'blog' not 'site' * Social | Use the proxy trait from connection package (#41087) * Update baseline.php * Update phan * Social | Fix social connections list initial state feature check (#41151) * Social | Enable connections management for WPCOM sites --------- Co-authored-by: Paul Bunkham <[email protected]>

* Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Social: Connections API schema front end changes (#40539) * Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Update connect-form.tsx * Create connections class for caching * Update types for connection object * Update connection actions to reflect new types * Mark 'id' as deprecated * Add changelog * Deprecated fields should be optional * Fix TS error * Update unit tests * Replace/remove deprecated props usage * Remove unused code * Fix connection selectors * Fix unit tests * Reduce the number of changes * Fix type * Oops! It should be negation * Restore class-connections.php * Social | Add site context for publicize endpoints (#40704) * Allow requests as blog in base controller * Add filters for connections controller * Add changelog * Update baseline.php * Rename the 'include' param to 'scope' for clarity * Return shared connections by default * Remove scope parameter in favour of request context * Only pass test_connections to WPCOM * Update baseline.php * Social: Implement connections caching with the updated endpoint (#40892) * Update connections class to implement caching * Add get_all_for_user method * Pass cached connections to initial state * Invalidate cache on XMLRPC request * Add changelog * Remove eager loading of connections following cache invalidation * Improve clear caching logic to handle race condition * Social: Replace can_disconnect with a store data selector (#40888) * Pass the connected users WPCOM data to the UI * Augment wpcom for user object * Create canUserManageConnection selector * Replace can_disconnect with the new selector * Fix unit tests * Add changelog * Fix user data for WPCOM sites * Fix unit tests * Add changelog * Social | Restore must_reauth as connection status (#40946) * Add "must_reauth" to status in REST schema * Restore the UI changes to consider must_reauth status * Add changelog * Don't disable connections with must_reauth status must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice. --------- Co-authored-by: Paul Bunkham <[email protected]> * Social | Clean up connections controller to use connections class (#40982) * Create Proxy_Requests class for re-usability * Move is_wpcom utility to Publicize_Utils class * Move connections specific logic from REST controller to connections class * Add changelog * Update baseline.php * Move publicize permissions check to its own method * Social | Fix connect button for broken connections (#40995) * Social | Fix connected accounts not marked as such on confirmation screen (#40997) * Social | Fix connected accounts not marked as such on confirmation screen * Add a comment * Social | Update connections schema to change `user_id` to `wpcom_user_id` (#41025) * Social | Update connections schema to change user_id to wpcom_user_id * Fix wpcom_user_id for post connections field * Add changelog * Social | Implement the other CRUD operations for connections (#40928) * WIP * Pass the connection ID in the URL * Pass connection_id for delete proxy request * Allow overriding $request_options * Clean up debugging * Add changelog * Add changelog for js changes * Fix static analysis issues * Remove unused code * Update baseline.php --------- Co-authored-by: Paul Bunkham <[email protected]> * Unify changelogs --------- Co-authored-by: Paul Bunkham <[email protected]>

* Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Social: Connections API schema front end changes (#40539) * Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Update connect-form.tsx * Create connections class for caching * Update types for connection object * Update connection actions to reflect new types * Mark 'id' as deprecated * Add changelog * Deprecated fields should be optional * Fix TS error * Update unit tests * Replace/remove deprecated props usage * Remove unused code * Fix connection selectors * Fix unit tests * Reduce the number of changes * Fix type * Oops! It should be negation * Restore class-connections.php * Social | Add site context for publicize endpoints (#40704) * Allow requests as blog in base controller * Add filters for connections controller * Add changelog * Update baseline.php * Rename the 'include' param to 'scope' for clarity * Return shared connections by default * Remove scope parameter in favour of request context * Only pass test_connections to WPCOM * Update baseline.php * Social: Implement connections caching with the updated endpoint (#40892) * Update connections class to implement caching * Add get_all_for_user method * Pass cached connections to initial state * Invalidate cache on XMLRPC request * Add changelog * Remove eager loading of connections following cache invalidation * Improve clear caching logic to handle race condition * Social: Replace can_disconnect with a store data selector (#40888) * Pass the connected users WPCOM data to the UI * Augment wpcom for user object * Create canUserManageConnection selector * Replace can_disconnect with the new selector * Fix unit tests * Add changelog * Fix user data for WPCOM sites * Fix unit tests * Add changelog * Social | Restore must_reauth as connection status (#40946) * Add "must_reauth" to status in REST schema * Restore the UI changes to consider must_reauth status * Add changelog * Don't disable connections with must_reauth status must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice. --------- Co-authored-by: Paul Bunkham <[email protected]> * Social | Clean up connections controller to use connections class (#40982) * Create Proxy_Requests class for re-usability * Move is_wpcom utility to Publicize_Utils class * Move connections specific logic from REST controller to connections class * Add changelog * Update baseline.php * Move publicize permissions check to its own method * Social | Fix connect button for broken connections (#40995) * Social | Fix connected accounts not marked as such on confirmation screen (#40997) * Social | Fix connected accounts not marked as such on confirmation screen * Add a comment * Social | Update connections schema to change `user_id` to `wpcom_user_id` (#41025) * Social | Update connections schema to change user_id to wpcom_user_id * Fix wpcom_user_id for post connections field * Add changelog * Social | Implement the other CRUD operations for connections (#40928) * WIP * Pass the connection ID in the URL * Pass connection_id for delete proxy request * Allow overriding $request_options * Clean up debugging * Add changelog * Add changelog for js changes * Fix static analysis issues * Remove unused code * Update baseline.php --------- Co-authored-by: Paul Bunkham <[email protected]> * Unify changelogs * Unify js changelog * It should be 'blog' not 'site' * Social | Use the proxy trait from connection package (#41087) * Update baseline.php * Update phan * Social | Fix social connections list initial state feature check (#41151) * Social | Enable connections management for WPCOM sites --------- Co-authored-by: Paul Bunkham <[email protected]>

manzoorwanijk added 3 commits January 10, 2025 11:17

Add "must_reauth" to status in REST schema

6a2756c

Restore the UI changes to consider must_reauth status

6457048

Add changelog

690e115

manzoorwanijk added [Type] Task [Status] Needs Team Review labels Jan 10, 2025

manzoorwanijk requested a review from a team January 10, 2025 05:56

manzoorwanijk self-assigned this Jan 10, 2025

github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [JS Package] Publicize Components [Package] Publicize [Tests] Includes Tests RNA labels Jan 10, 2025

Don't disable connections with must_reauth status

1afa097

must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice.

pablinos approved these changes Jan 10, 2025

View reviewed changes

manzoorwanijk merged commit b1f7eb4 into social/unified-connections-management Jan 10, 2025
56 checks passed

manzoorwanijk deleted the update/social-add-back-must_reauth-as-connection-status branch January 10, 2025 17:41

github-actions bot removed the [Status] Needs Team Review label Jan 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Social | Restore must_reauth as connection status #40946

Social | Restore must_reauth as connection status #40946

manzoorwanijk commented Jan 10, 2025

github-actions bot commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025

pablinos left a comment

Social | Restore must_reauth as connection status #40946

Social | Restore must_reauth as connection status #40946

Conversation

manzoorwanijk commented Jan 10, 2025

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 10, 2025 • edited Loading

github-actions bot commented Jan 10, 2025

pablinos left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 10, 2025 •

edited

Loading