commit label updates #3046 #3048
Conversation
| @@ -9,10 +9,10 @@ | |||
| <tbody data-bind="foreach: rows"> | |||
| <tr class="header"> | |||
| <th class="code"></th> | |||
| <th class="outcome required">Outcome statement/s</th> | |||
| <th class="outcome required">${outcomeStatementHeading ?: 'Outcome Statement/s'}</th> | |||
There was a problem hiding this comment.
Looks like most of the other default headings are sentence case - should probably use sentence case here as well.
There was a problem hiding this comment.
ready for retesting
| @@ -18,7 +18,7 @@ | |||
| </g:else> | |||
| <th class="outcome required">${subtitle ?: ""} <g:if test="${helpText}"><fc:iconHelp html="true" container="body">${helpText}</fc:iconHelp></g:if> </th> | |||
| <g:if test="${extendedOutcomes}"> | |||
| <th class="investment-priority required">Investment Priority</th> | |||
| <th class="investment-priority required">${investmentPriorityHeading ?: 'Investment Priority'}</th> | |||
There was a problem hiding this comment.
Use sentence case for default
There was a problem hiding this comment.
ready for retesting
#3041 is also ready for testing, updates were pushed using the same feature branch |
| @@ -4,7 +4,7 @@ | |||
| <table class="table"> | |||
| <thead> | |||
| <tr> | |||
| <th>Project methodology</th> | |||
There was a problem hiding this comment.
This should be templated using the same variable/s as meriPlan/_projectMethodology.gsp - otherwise this will just cause RLP labels to be wrong.
| @@ -1,7 +1,7 @@ | |||
| <table class="table"> | |||
| <thead> | |||
| <tr> | |||
| <th>Project Review, Evaluation and Improvement Methodology and Approach</th> | |||
There was a problem hiding this comment.
This should be templated to match meriPlan/_projectReview.gsp
| @@ -11,9 +11,14 @@ | |||
| <g:else> | |||
| <th class="code"></th> | |||
| </g:else> | |||
| <th class="outcome">Outcome statement/s</th> | |||
| <g:if test="${outcomeType == 'mid'}"> | |||
There was a problem hiding this comment.
This should be templated as per meriPlan/_outcomeStatements.gsp
| @@ -5,13 +5,13 @@ | |||
| <thead> | |||
| <tr> | |||
| <th class="index"></th> | |||
There was a problem hiding this comment.
This should be templated as per /meriPlan/_monitoringIndicators.gsp
| @@ -4,7 +4,7 @@ | |||
| <table class="table"> | |||
| <thead> | |||
There was a problem hiding this comment.
This should be templated as per /meriPlan/_projectMethodology.gsp
| @@ -2,7 +2,7 @@ | |||
| <table class="table secondary-outcome"> | |||
| <thead> | |||
| <tr> | |||
| <th class="outcome-priority">Secondary outcome(s)</th> | |||
There was a problem hiding this comment.
This should be templated as per /meriPlan/_addionalOutcomes.gsp
No description provided.