Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #235

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Spelling #235

merged 1 commit into from
Dec 13, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jul 21, 2022

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@6e02e3c#commitcomment-79066923

The action reports that the changes in this PR would make it happy: jsoref@2110bdd

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most corrections were automatically suggested by Google Sheets. All fault is mine.

If certain files come from upstreams, I can try to send patches to them as well (although I have a long list, so there's no particular time guarantee for such activity), and I can certainly easily drop any particular files...

proxyclient/hv/trace_dcp.py Outdated Show resolved Hide resolved
@@ -7,7 +7,7 @@
DebuggerState = Struct(
"panic_options" / Hex(Int64ul),
"current_op" / Hex(Int32ul),
"proceed_on_sync_failre" / Int32ul,
"proceed_on_sync_failure" / Int32ul,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andy9a9
Copy link

andy9a9 commented Jul 21, 2022

Isn't possible to squash all commits into one, like style?
On the other hand, isn't a duplicate of #234?

@jsoref
Copy link
Contributor Author

jsoref commented Jul 21, 2022

codespell only handles common mistakes. check-spelling covers misspellings in general.

I'm happy to squash, but only once people are happy w/ the changes. Often people object to some set of my changes.

Comment on lines -664 to +878
D400 = Callback(void, "get_property", obj=FourCC, key=string(0x40), value=OutPtr(Bytes(0x200)), lenght=InOutPtr(uint))
D400 = Callback(void, "get_property", obj=FourCC, key=string(0x40), value=OutPtr(Bytes(0x200)), length=InOutPtr(uint))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argument change

@marcan
Copy link
Member

marcan commented Aug 30, 2022

I think this is fine to merge, but can you fix the conflicts?

src/minilzlib/lzmadec.c Outdated Show resolved Hide resolved
@marcan
Copy link
Member

marcan commented Dec 12, 2023

Rebased, fixed the conflicts, and squashed. Just one more thing though, can you change the commit author / signoff to a real email instead of the weird github noreply thing? If you tell me what email to use (and consent) I can do it for you too.

Thanks :)

@jsoref
Copy link
Contributor Author

jsoref commented Dec 12, 2023

[email protected], and sure, go for it.

Correct misspellings identified by the check-spelling action.

Signed-off-by: Josh Soref <[email protected]>
@marcan marcan merged commit e52eaf4 into AsahiLinux:main Dec 13, 2023
3 checks passed
@jsoref jsoref deleted the spelling branch December 13, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants