topology: fix overzealous deprecation check in listpeerchannels.

It's an output field (which we don't complain about), not an input field! Fixes: ElementsProject#7652 Changelog-Fixed: Logging: removed bogus "**BROKEN** plugin-topology: DEPRECATED API USED: listchannels.include_private" message. Signed-off-by: Rusty Russell <[email protected]>
AreaLayer · Sep 16, 2024 · bfe0557 · bfe0557
1 parent 7e2ea3e
commit bfe0557
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/plugins/topology.c b/plugins/topology.c
@@ -394,7 +394,7 @@ static struct command_result *listpeerchannels_done(struct command *cmd,
 	struct gossmap_localmods *mods;
 
 	/* In deprecated mode, re-add private channels */
-	if (command_deprecated_in_ok(cmd, "include_private", "v24.02", "v24.08")) {
+	if (command_deprecated_out_ok(cmd, "include_private", "v24.02", "v24.08")) {
 		connected = local_connected(opts, buf, result);
 		mods = gossmods_from_listpeerchannels(tmpctx, &local_id,
 						      buf, result, false,

diff --git a/tests/test_plugin.py b/tests/test_plugin.py
@@ -4417,7 +4417,6 @@ def test_sql_crash(node_factory, bitcoind):
     l1.rpc.sql(f"SELECT * FROM peerchannels;")
 
 
-@pytest.mark.xfail(strict=True)
 def test_listchannels_broken_message(node_factory):
     """This gave a bogus BROKEN message with deprecated-apis enabled"""
     l1 = node_factory.get_node(options={'allow-deprecated-apis': True})