fix macros for compiling in MDK5 with armcc #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
Jun 19, 2017
| @@ -15,6 +15,10 @@ namespace mavlink { | |||
| // Macro to define packed structures | |||
| #ifdef __GNUC__ | |||
| #define MAVPACKED( __Declaration__ ) __Declaration__ __attribute__((packed)) | |||
| #elif defined __arm__ | |||
There was a problem hiding this comment.
Could you find a tighter constraint on the check here?
Does __UVISION_VERSION work?
There was a problem hiding this comment.
Yes. I tried, and it works.
There was a problem hiding this comment.
Could we use the macro __ARMCC_VERSION instead, which is the predefined macro for ARM KEIL compiler, while __UVISION_VERSION is related with MDK IDE environment.
|
On Mon, 19 Jun 2017, Zheng GONG wrote:
Could we use the macro __ARMCC_VERSION instead, which is the predefined
macro for ARM KEIL compiler, while __UVISION_VERSION is related with MDK IDE
environment.
So long as nobody else produces a compiler called "armcc" we're probably
good with that :-)
|
|
Tested it just now. Works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/oceanstack/MAVLink_MDK_STM32, adjust some macro defines for armcc compiler in Kail uVision5 embed-system develpment environment.